Replace rpath to remove if possible #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the rpath to remove is available, replace it with an rpath that is to be added to the target file. This prevents errors as seen with the curl library where simply adding and removing rpaths would cause a command load error within the library.
|
@chrisroberts Is there an ETA on releasing this in 1.8.8? It is impacting us here at uber. |
mitchellh
approved these changes
Nov 9, 2016
|
(And on pretty much every other project that uses Vagrant and has developers using macOS) ;) |
|
Echoing what I posted in #7969...
I'm starting to count the number of pings via email, GH, Twitter, etc., and it's up to about 5 per day now. I can only imagine how much worse it is for larger projects that rely on Vagrant and have a sizable Mac-using community... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the rpath to remove is available, replace it with an rpath
that is to be added to the target file. This prevents errors as
seen with the curl library where simply adding and removing rpaths
would cause a command load error within the library.
Fixes: hashicorp/vagrant#7969