Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: Use existing ssh command if available on Windows platform instead of just failing #1156

Closed
wants to merge 2 commits into from

Conversation

tknerr
Copy link
Contributor

@tknerr tknerr commented Sep 26, 2012

This is the same patch as in #1083 but merges cleanly with 1-0-stable rather than master.

The goal is to enable vagrant ssh on windows if a Cygwin ssh is avaible.

@mitchellh : any chance this would make it into 1.0.6?

@gaffo
Copy link

gaffo commented Oct 17, 2012

Mitchell, can you please pull one of these windows fixes so I can stop monkey patching my vagrant installs? Pretty Please!

@gaffo
Copy link

gaffo commented Oct 30, 2012

@mitchellh any word on this?

@smerchek
Copy link

This would be really helpful for me as well. I was surprised that it didn't even try. As it is, I've created a custom alias for vagrantssh, certainly not the most ideal, especially when I start to share vagrant boxes with my coworkers.

@mitchellh
Copy link
Contributor

Sorry I don't want to push features back into the 1.0.x line. It is only for critical bugs. Please upgrade to 1.1+ if you want this feature.

@mitchellh mitchellh closed this Jul 11, 2013
@gaffo
Copy link

gaffo commented Jul 11, 2013

That's fine now that there is something to upgrade to

Sent from my Sprint phone

-------- Original message --------
From: Mitchell Hashimoto notifications@github.com
Date: 07/11/2013 03:27 (GMT-08:00)
To: mitchellh/vagrant vagrant@noreply.github.com
Cc: Mike Gaffney mike@uberu.com
Subject: Re: [vagrant] Re: Use existing ssh command if available on Windows platform instead of just failing (#1156)

Sorry I don't want to push features back into the 1.0.x line. It is only for critical bugs. Please upgrade to 1.1+ if you want this feature.


Reply to this email directly or view it on GitHub.

@tknerr
Copy link
Contributor Author

tknerr commented Jul 11, 2013

@mitchellh sure, I'm on 1.2.2 and happy to the issue solved there. No need for me to get this backported to 1.0.x now that 1.1+ is out 👍

Now that ssh is fixed for the poor windows users out there, it would super-awesome if the shared-folders via rsync (which almost any cloud provider uses) would become windows-compatible as well.

There is mitchellh/vagrant-aws#77 outstanding which fixes this for the vagrant-aws provider specifically, but it would probably be better to provide a common RsyncFolders action in vagrant core which could be reused by any provider (since this is such a common thing).

@tknerr
Copy link
Contributor Author

tknerr commented Jul 13, 2013

for rsync on windows see #1926

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants