Adds formatter option to Chef Provisioner #1250
Conversation
|
+1, this would be great! |
|
@mitchellh any feedback on this? Came up again as something I was curious about using today. |
|
@miketheman It looks good but I'm not accepting patches back against 1.0 anymore. If you get this to work again 1.x I'll merge right away. Thanks! |
|
Sure thing. This was submitted while 1.1/2 were still unreleased. |
Adds formatter option to Chef Provisioner [GH-1250]
| @@ -28,5 +28,7 @@ https_proxy_pass <%= https_proxy_pass.inspect %> | |||
| no_proxy <%= no_proxy.inspect %> | |||
|
|
|||
| pid_file "/var/run/chef/chef-client.pid" | |||
|
|
|||
| <% if formatter %> | |||
| formatter "<%= formatter %>" | |||
There was a problem hiding this comment.
this should be add_formatter because formatter does not work :-(
see http://lists.opscode.com/sympa/arc/chef/2013-08/msg00071.html
|
Ah, that's why it didn't work when I have it a try couple of days ago.. |
|
I'm confused - formatter works for chef-client, but not chef-solo? |
|
That's really strange if it works with chef-client. I have tested with chef-solo only... |
|
@miketheman is this chef-client 10.x or 11.x where @danielsdeleo mentioned on the chef list that this could be the issue. |
|
@tknerr Just spent some time verifying this. A total kludge would be to add both statements into the config file, and I'm not a fan of that - it's grosstastic. I think The Right Thing would be to use the Thoughts? |
Refs hashicorp#1250. Will correctly produce the desired result on Chef 11.x and above, as the original directive was written against Chef 10.x, and released in Vagrant 1.2.7. While this will continue to work for Chef 10.x, since this is not the 'mainline' release track, and the alternative would be to write more conditional code in the configuration file to detect the version and place the correct directive, this changes the directive to support the current releases of Chef 11 and above.
|
@miketheman can we conditionally include either the one or the other? Do we know the Chef version here? @danielsdeleo is 'add_formatter' likely to stick past Chef 11 |
|
I'm 👍 for Chef 11 otherwise :-) |
|
@tknerr I don't think the version comes through to the provisioner, and adding that seems like the kludge I mentioned earlier. |
|
@miketheman yeah, having both statements in the rendered template would be kludgy. The only way I could think of would be to shell out to 'knife -v' while the template is rendered (assuming it's rendered on the guest vm), but that's probably not much better... Chef 11 would be fine for me |
|
Great. @mitchellh @fgrehm this is ready to whenever you want to press the big green button. |
|
@miketheman Cool, I'm heading on vacation today for a week, if Mitchell is not able to handle it feel free to ping me by then ;) |
ghost
locked and limited conversation to collaborators
Adds the ability to specify in the Vagrantfile a formatter directive to control the verbosity/format of the Chef log.
Formats such as
summary,minimalanddocare valid, and the directive is not required.I tried taking a stab at the tests, but the test suite didn't seem very friendly to me today.