Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal to user to run download_fontawesome(version = "dev") #67

Closed
ddsjoberg opened this issue Feb 13, 2022 · 2 comments
Closed

Signal to user to run download_fontawesome(version = "dev") #67

ddsjoberg opened this issue Feb 13, 2022 · 2 comments
Assignees

Comments

@ddsjoberg
Copy link

Hello! Thank you for making these cute icons easily available to us!

I recently got a new computer, and was running some old scripts that use the icons pkg. I kept seeing an error from icons::fontawesome("twitter") that there was a subscript out of bounds. The solution was to first run download_fontawesome(version = "dev"), but I was pretty confused for quite a while before remembering about this step.

I think it would be helpful if there was some error messaging reminding users this may be the solution. Perhaps something like this?

icons::fontawesome("twitter")
#> Error: Subscript out of bounds
#> Have you run `download_fontawesome(version = "dev")` already?

Thanks again!

PS I am on Windows 10 if that matters

@ddsjoberg
Copy link
Author

Awesome, thank you!

@mitchelloharawild
Copy link
Owner

Thanks for your suggestion! Definitely a more helpful error (and better code practices) was needed here 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants