❓ Add icon_guess function for better icon finding error

Resolves #67
mitchelloharawild · Aug 10, 2023 · 2dbcb3d · 2dbcb3d
1 parent 665fd9c
commit 2dbcb3d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/R/fontawesome.R b/R/fontawesome.R
@@ -37,7 +37,7 @@ fontawesome <- new_icon_set(
   "fontawesome",
   function(name, style = NULL){
     if(is.null(style)){
-      icon_find(name, "fontawesome")[[1]]
+      icon_guess(name, "fontawesome")
     } else {
       icon_fn$get(c(style, name))
     }

diff --git a/R/google_material.R b/R/google_material.R
@@ -99,15 +99,7 @@ google_material <- new_icon_set(
   "google_material",
   function(name, category = NULL, theme = NULL){
     if(is.null(category)){
-      x <- icon_find(name, "google_material")
-      if(is.null(theme)) {
-        x[[1]]
-      } else {
-        if(length(pos <- which(grepl(theme, names(x), fixed = TRUE))) != 1) {
-          abort("Could not find this specific icon from google_material.")
-        }
-        x[[pos]]
-      }
+      icon_guess(name, "google_material", pattern = theme)
     } else {
       icon_fn$get(c(theme, category, name))
     }

diff --git a/R/utils.R b/R/utils.R
@@ -88,3 +88,15 @@ install_icon_zip <- function(lib, url, svg_path, svg_pattern = "\\.svg$",
 
   return(dl_dir)
 }
+
+icon_guess <- function(name, ..., pattern = NULL) {
+  icon_found <- icon_find(name, ...)
+  if(!is.null(pattern)) {
+    icon_found <- icon_found[grepl(pattern, names(icon_found), fixed = TRUE)]
+  }
+
+  if(rlang::is_empty(icon_found)) {
+    abort(sprintf("The %s icon could not be found. Perhaps its icon set needs installing or updating?", name))
+  }
+  icon_found[[1]]
+}