-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Rewrite icon package #31
Merged
mitchelloharawild
merged 128 commits into
mitchelloharawild:master
from
mitchelloharawild:rewrite
Dec 13, 2020
Merged
🚀 Rewrite icon package #31
mitchelloharawild
merged 128 commits into
mitchelloharawild:master
from
mitchelloharawild:rewrite
Dec 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2020
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the package to improve maintainability and performance. This chance will also move the repository from ropenscilabs/icon to its new home at mitchelloharawild/icon.
New icon sets
simple_icons()
icon set (https://github.com/simple-icons/simple-icons/).material_design()
icon set (https://github.com/google/material-design-icons/).Breaking changes
iconset_icon
interface for accessing theicon
icon from theiconset
icon set has been replaced withiconset$icon
.iconset()
interface for accessing the icons is now specific to each icon library.fa
,ii
, etc.) have been replaced with longer, more informative names (fontawesome
,ionicons
, etc.).Improvements
download_*()
helpers can be used to install icon libraries.word_document
andgithub_document
output formats.Bug fixes