Skip to content

Commit

Permalink
beets: disable failing test
Browse files Browse the repository at this point in the history
Reported here: beetbox/beets#4836
  • Loading branch information
doronbehar authored and mitchmindtree committed Jul 2, 2023
1 parent baf490d commit 213ce43
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkgs/tools/audio/beets/common.nix
Expand Up @@ -52,6 +52,9 @@ python3Packages.buildPythonApplication rec {
patches = [
# Bash completion fix for Nix
./patches/bash-completion-always-print.patch
# Reported upstream at:
# https://github.com/beetbox/beets/issues/4836
./patches/remove-failing-embedart-test.patch
(fetchpatch {
# Fix unidecode>=1.3.5 compat
url = "https://github.com/beetbox/beets/commit/5ae1e0f3c8d3a450cb39f7933aa49bb78c2bc0d9.patch";
Expand Down
24 changes: 24 additions & 0 deletions pkgs/tools/audio/beets/patches/remove-failing-embedart-test.patch
@@ -0,0 +1,24 @@
diff --git i/test/test_embedart.py w/test/test_embedart.py
index 23a6f5e5..91b9c8c2 100644
--- i/test/test_embedart.py
+++ w/test/test_embedart.py
@@ -163,19 +163,6 @@ class EmbedartCliTest(TestHelper, FetchImageHelper):
'Image written is not {}'.format(
displayable_path(self.abbey_artpath)))

- @require_artresizer_compare
- def test_accept_similar_art(self):
- self._setup_data(self.abbey_similarpath)
- album = self.add_album_fixture()
- item = album.items()[0]
- self.run_command('embedart', '-y', '-f', self.abbey_artpath)
- config['embedart']['compare_threshold'] = 20
- self.run_command('embedart', '-y', '-f', self.abbey_similarpath)
- mediafile = MediaFile(syspath(item.path))
-
- self.assertEqual(mediafile.images[0].data, self.image_data,
- 'Image written is not {}'.format(
- displayable_path(self.abbey_similarpath)))

def test_non_ascii_album_path(self):
resource_path = os.path.join(_common.RSRC, b'image.mp3')

0 comments on commit 213ce43

Please sign in to comment.