Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Short title of the bug #155

Closed
martinkiska opened this issue Nov 21, 2022 · 0 comments
Closed

[BUG]: Short title of the bug #155

martinkiska opened this issue Nov 21, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@martinkiska
Copy link

Describe the bug

ZCC class of this SDK is not possible to list all registered devices to mobile portal. This creates difficulties while trying to filter devices according to version which is installed

To Reproduce
zcc = ZCC(
client_id=CLIENT_ID,
client_secret=CLIENT_SECRET,
customer_id=CUSTOMER_ID,
)

json = {"pageSize": "1000"}
devices = zcc.devices.list_devices()
devices_get = zcc.get("public/v1/getDevices", params=json)
print(f"Len of devices is {len(devices)}")
print(f"Len of devices_get is {len(devices_get)}")

Results:
Len of devices is 50
Len of devices_get is 1000

Expected behavior

Currently zcc.devices.list_devices() doesn't accept any kwargs. I would expect, that zcc.devices.list_devices() function could accept additional params - for example pageSize definition which would allow to download more devices. Still while discussing it with vendor support I found out that API is able to list only 5k of devices and not more. But this is more related to vendor support not to your SDK.

(Case Number : 03648320 - I just received a confirmation that the maximum number of devices from the pageSize parameter is 5000. )

Additional context

My reason for that - we had received custom ZCC version with fix of one bug. I wanted to check if all users have installed that version - it was absolutely impossible without your SDK and this pageSize increase.

@martinkiska martinkiska added the bug Something isn't working label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants