Missing SFDX Scanner CLI Options
#3
Labels
enhancement
New feature or request
Comments
mitchspano
added a commit
that referenced
this issue
Aug 3, 2022
mitchspano
added a commit
that referenced
this issue
Aug 3, 2022
… | `node_modules` instead of Vercel (#8) - Rename `getDiffSinceLastCommit` to `getDiffInPullRequest`#2 - Support additional attributes passed into the scan command #3 - Gracefully exit is there are no applicable files found in the git difference between the branches in the pull request #5 - Get rid of vercel created dist folder - use node_modules instead
mitchspano
pushed a commit
that referenced
this issue
Mar 19, 2023
* Converting to typescript * Removing node_modules * Finished porting to tsbuild and successfully wrapped the SFDX cli to support ts build tree shaking for the scanner * Properly taking into account async nature of CLI requests, added a few additional scanner violation properties to the ScannerViolation type while looking through some of the scanner output! * Added basic jest test showing how an example class's violations are returned to the caller * Minor cleanup * Removing .sfdx/ dir * Added simple-git tests, separated out git-related logic into src/git-actions.ts * Updating action.yml file to point to correct path * Adding some notes in src/sfdxCli.ts for Mitch to provide additional context * Cleaning up git-actions.ts a bit to remove implicit coupling between destination magic string as git remote name * Fixing broken binding between --target argument and better encapsulated how CLI args are passed * Updated pinned SFDX dependency, which allowed for less ceremony in testing as the oclif dependencies for SFDX no longer required mocking. Added a falsy config option for the scanner flags to show both sides of the ternary working when mapping config values to command line values for the CLI to read * Updating oclif/core depedency which allows us to cut out the fs dependency when interacting with sfdx scanner results * Updated dist version - made notes in sfdxCli.ts about additional work necessary to ensure scanner is installed * Removing TODO as it seems part of the intentional design of the action * Adding stubbed out method to install scanner if not already present on the filesystem * Fixes #4 by linking sfdx-scanner on the fly when it hasn't already been used earlier on in a pipeline run * Awkwardly fixes tree shaking (with some false positives that display when running the esbuild command) by importing direct references to a few eslint-related objects, the scanner itself, and espree (which is, at least for now, a dependency of eslint). Added jest unit test for eslint rules with an example LWC * Fixes bundling issues * Testing local runs (#2) * Adding example action file for local run testing * Testing vercel/ncc as the bundler in replacement of esbuild * Got local runs working * Updating deps and moving to one context object * Simplifying a few things * Adding example command for using act locally. Requires a .env file with a GITHUB_TOKEN variable to run properly * Modifying sfdxCli.ts to use npx for node_module resolution * Fixed up running logic (#3) * Refactoring to support comments on github commits * Updating changed line logic to include files part of a targeted run * Fixing map syntax * Fixing HTML table rendering for comments * Testing basic comment * Moved from copying files to providing comma-separated list of file name changes to scanner * Inverted args so that diff is created the right way * Updating to correct commit sha for PRs * Updated README to reflect recursive-copy dependency having been removed * Removed unused dependencies from package.json and package-lock.json. Updated TODO comment for comment resolution based on @jongpie and me prototyping that today * Verifying PR comments still work * Fixing up tests * adding file to scan violation message * Using commit sha as file link * Filtering existing comments for only those left by the bot * Matching existing comments now that body also includes commit Id * Code review updates based on @jongpie feedback * calling setFailed explicitly for hasHaltingError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Many of the
sfdx scannerplugin CLI options are missing support in the defined metadata inputs for the actionThe text was updated successfully, but these errors were encountered: