Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Destination" origin to allow cross repo PRs #24

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Add "Destination" origin to allow cross repo PRs #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
npm install sfdx-cli
node_modules/sfdx-cli/bin/run plugins:install @salesforce/sfdx-scanner
- name: Run SFDX Scanner - Report findings as comments
uses: mitchspano/sfdx-scan-pull-request@v0.1.3
uses: mitchspano/sfdx-scan-pull-request@v0.1.5
with:
pmdconfig: ruleset.xml
severity-threshold: 4
Expand Down
6 changes: 5 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ function validatePullRequestContext() {
function getDiffInPullRequest() {
console.log("Getting difference within the pull request...");
execSync(
`git diff origin/${this.pullRequest?.base?.ref}...origin/${this.pullRequest?.head?.ref} > ${DIFF_OUTPUT}`
`git remote add -f destination ${this.pullRequest.base.repo.clone_url}`
);
execSync(`git remote update`);
execSync(
`git diff destination/${this.pullRequest?.base?.ref}...origin/${this.pullRequest?.head?.ref} > ${DIFF_OUTPUT}`
);
const files = parse(fs.readFileSync(DIFF_OUTPUT).toString());
for (let file of files) {
Expand Down