Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Client Secret and Subscription Secret Should be Separate #34

Closed
mitchwadair opened this issue Aug 7, 2021 · 1 comment · Fixed by #35
Closed

[BUG] Client Secret and Subscription Secret Should be Separate #34

mitchwadair opened this issue Aug 7, 2021 · 1 comment · Fixed by #35
Assignees
@mitchwadair
Labels
bug Something isn't working

Comments

@mitchwadair
Copy link
Owner

Describe the bug
According to the doc, you should not use your Client Secret as the secret for your EventSub subscriptions. This needs to be changed.
@mitchwadair mitchwadair added the bug Something isn't working label Aug 7, 2021
mitchwadair added a commit that referenced this issue Aug 23, 2021
@mitchwadair
#34: separate client and wh secrets
760f23e
@mitchwadair
Copy link
Owner Author

Was originally going to release this along with websocket support, but I think it is too important not to ship. I'll be releasing the fix to this soon and will be highly recommending an upgrade, even though this will be a breaking change.

mitchwadair added a commit that referenced this issue Aug 23, 2021
@mitchwadair
#34: separate client secret and wh secret
16d91c0
mitchwadair added a commit that referenced this issue Aug 23, 2021
@mitchwadair
#34: update doc for secrets change
7e22d0a
mitchwadair added a commit that referenced this issue Aug 23, 2021
@mitchwadair
#34: add version disclaimer to README
28cd329
@mitchwadair mitchwadair self-assigned this Aug 24, 2021
@mitchwadair mitchwadair mentioned this issue Aug 24, 2021
Merged
mitchwadair added a commit that referenced this issue Aug 27, 2021
@mitchwadair
Merge pull request #35 from mitchwadair/development
09372e4 
#34: Update to Separate Client and Webhooks Secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchwadair mitchwadair

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#34: Update to Separate Client and Webhooks Secrets mitchwadair/tesjs
1 participant
@mitchwadair