Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFE] Handle Duplicate Messages #8

Closed
mitchwadair opened this issue Dec 1, 2020 · 0 comments · Fixed by #10
Closed

[RFE] Handle Duplicate Messages #8

mitchwadair opened this issue Dec 1, 2020 · 0 comments · Fixed by #10
Assignees
@mitchwadair
Labels
enhancement New feature or request

Comments

@mitchwadair
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently if a duplicate notification is received, the event will fire again. TESjs should handle these cases (configurable?)

Describe the solution you'd like
Keep track of a list of message IDs received and ignore ones that have been seen already.

  • could be a configurable option
    • true by default
@mitchwadair mitchwadair added the enhancement New feature or request label Dec 1, 2020
@mitchwadair mitchwadair self-assigned this Dec 1, 2020
mitchwadair added a commit that referenced this issue Dec 2, 2020
@mitchwadair
#8/#9 <tes/whserver>: add config for message ignore
dd6a242
mitchwadair added a commit that referenced this issue Dec 2, 2020
@mitchwadair
#8/#9 <tesjs>: default true for new configs
3e82123
mitchwadair added a commit that referenced this issue Dec 2, 2020
@mitchwadair
#8/#9 <whserver>: add debug logs
7c74001
mitchwadair added a commit that referenced this issue Dec 2, 2020
@mitchwadair
#8/#9 <test>: add/change tests for updated func
c7acac2
mitchwadair added a commit that referenced this issue Dec 2, 2020
@mitchwadair
#8/#9 <doc>: update config doc for changes
3672a84
@mitchwadair mitchwadair mentioned this issue Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchwadair mitchwadair

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add New Configs/Revocation Event mitchwadair/tesjs
1 participant
@mitchwadair