Add new getSubscriptions Functions, Change Handler Payload, etc. #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a couple of new getSubscriptions functions described in #17. It also changes the event handler payload to be the event object rather than spreading the event into separate arguments because it is not guaranteed to be the same order each time. This will also set TESjs up to be more resilient to EventSub changes in the future (see #18).
This PR also includes doc changes for the above, as well as a fix for inconsistency described in #19.
Additions
getSubscriptionsByType
functiontype
(required), secondcursor
(optional)getSubscriptionsByStatus
functionstatus
(required), secondcursor
(optional)_getSubs
to consolidate code related to the above additionsChanges
getSubscriptions
to utilize_getSubs
'private' functiongetSubscription
when using type/condition to usegetSubscriptionsByType
for efficiencyTesting
Updated test cases for event handlers. Also ran through some black-box testing for the new functions and did not see any glaring issues.