Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new getSubscriptions Functions, Change Handler Payload, etc. #20

Merged
merged 12 commits into from
Jan 12, 2021

Conversation

mitchwadair
Copy link
Owner

Description

This PR adds a couple of new getSubscriptions functions described in #17. It also changes the event handler payload to be the event object rather than spreading the event into separate arguments because it is not guaranteed to be the same order each time. This will also set TESjs up to be more resilient to EventSub changes in the future (see #18).

This PR also includes doc changes for the above, as well as a fix for inconsistency described in #19.

Additions

Changes

Testing

Updated test cases for event handlers. Also ran through some black-box testing for the new functions and did not see any glaring issues.

@mitchwadair mitchwadair merged commit b4b0f9d into main Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant