Drawer opens when it should not #37
Comments
emem365
added a commit
to emem365/Best-Flutter-UI-Templates
that referenced
this issue
May 20, 2020
As the issue states, the drawer was opening when it shouldn't. The problem was that sometimes there was a minute difference between scrollController.offset and widget.drawerWidth (294.54545454545456 and 294.54545454545455, in my case), and thus the correct function was not being executed. I have changed the > < if condition when adding the Listener to scrollController to compare with the floor value instead, (294, in my case). Since the change is quite less, I figure this should work fine :)
|
Hi @mitesh77, I really appreciate what you've done with flutter here. I was looking around your examples when I faced the same issue. I managed to fix it for my fork of the repo. If this repo is open to PRs, maybe you can merge it to the master :) |
|
I can confirm, fix works fine. I think issue can be closed. |
eugene2candy
pushed a commit
to eugene2candy/Best-Flutter-UI-Templates
that referenced
this issue
Apr 10, 2021
As the issue states, the drawer was opening when it shouldn't. The problem was that sometimes there was a minute difference between scrollController.offset and widget.drawerWidth (294.54545454545456 and 294.54545454545455, in my case), and thus the correct function was not being executed. I have changed the > < if condition when adding the Listener to scrollController to compare with the floor value instead, (294, in my case). Since the change is quite less, I figure this should work fine :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test on Android.
To reproduce:
On some phones it's even worse, drawer always opens itself and I am unable to click anything in window. It depends from font size and dpi used.
Drawer is buggy, please look?
The text was updated successfully, but these errors were encountered: