Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloneRotXYZ and replace accompanying tests with cloneTrot since this won't be used anymore #30

Closed
mithi opened this issue Jun 7, 2020 · 1 comment
Labels
best practice Best practice in software development

Comments

@mithi
Copy link
Owner

mithi commented Jun 7, 2020

The best practice i've discovered is to compute the transformation matrix outside and pass it
to the hexagon. This is because usually we use the same transformation matrix not only to the hexagon but other things like legs or coordinate frames (axes). So we'll just compute the transformation matrix only once for all the objects that need it. This is why we don't need these kinds of abstractions anymore.

cloneRotXYZshift(thetaX, thetaY, thetaZ, tx, ty, tz) {

@mithi mithi added the best practice Best practice in software development label Jun 7, 2020
@mithi mithi changed the title Remove cloneRotXYZ and replace accompanying tests since this won't be used anymore Remove cloneRotXYZ and replace accompanying tests with cloneTrot since this won't be used anymore Jun 7, 2020
@mithi
Copy link
Owner Author

mithi commented Jun 8, 2020

6e8d8d5

@mithi mithi closed this as completed Jun 8, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Best practice in software development
Projects
None yet
Development

No branches or pull requests

1 participant