Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Remove mathjs dependency (fixes #77) #81

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

mithi
Copy link
Owner

@mithi mithi commented Jun 22, 2020

No description provided.

@mithi mithi linked an issue Jun 22, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #81 into master will increase coverage by 0.89%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   57.25%   58.15%   +0.89%     
==========================================
  Files          48       48              
  Lines        1165     1190      +25     
  Branches      144      144              
==========================================
+ Hits          667      692      +25     
  Misses        454      454              
  Partials       44       44              
Impacted Files Coverage Δ
src/hexapod/solvers/twistSolver.js 45.23% <0.00%> (ø)
src/hexapod/Linkage.js 97.05% <100.00%> (ø)
src/hexapod/Vector.js 77.77% <100.00%> (+5.05%) ⬆️
src/hexapod/geometry.js 96.84% <100.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d9e13...b154ae1. Read the comment docs.

@mithi mithi merged commit 8cdc22d into master Jun 22, 2020
@mithi mithi deleted the remove-mathjs-dependency branch June 22, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite math operations so we won't use mathjs a dependency
1 participant