Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete df feature #233

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Delete df feature #233

wants to merge 6 commits into from

Conversation

ShannonSD
Copy link
Contributor

Adds a memory quota that tracks the memory consumption of each user. The default value is 5 MB and is set in the config.toml.
Authentication must be enabled for memory quotas to work.
Deletion of a dataframe releases the memory it consumed for the user who created it. Dataframes can be deleted by either the data owner or the data scientist that created the dataframe.

A notebook called memory_quotas is added in tutorials, it describes memory_quotas and how to delete dataframes. The python server is modified to support authentication for this notebook. However, since the python server is still based off the last available release, the deserialization of the policy fails. This will be fixed by a new release of the python server.

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
380 367 97% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f1f114e by action🐍

@ShannonSD
Copy link
Contributor Author

The test notebook fails because of the changes I made to the python server to add authentication. It passes an argument to enable authentication and the test notebook expects no arguments.

@dhalf dhalf added A-client Area: Client A-server Area: Server C-feature Category: Feature P-high Priority: High S-delayed State: delayed labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: Client A-server Area: Server C-feature Category: Feature P-high Priority: High S-delayed State: delayed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants