Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mithril to a peerDependency #76

Closed
bdchauvette opened this issue Nov 1, 2017 · 0 comments
Closed

Move mithril to a peerDependency #76

bdchauvette opened this issue Nov 1, 2017 · 0 comments

Comments

@bdchauvette
Copy link
Contributor

This is how react-dom and React Native handle their dependency on React, and would help prevent issues like #58 in the future. I imagine most users consuming this module probably already have Mithril installed as a dependency, so you wouldn't run into the peerDependency hell that you do with e.g. eslint plugins and presets.
bdchauvette added a commit to bdchauvette/mithril-node-render that referenced this issue Nov 1, 2017
@bdchauvette
Make mithril a peer dependency - fixes MithrilJS#76
f3c9b70 
Also bump mithril from 1.1.3 to 1.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bdchauvette