Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mithro/actions-includes@main work with private workflows #18

Open
piotrlis opened this issue Mar 17, 2021 · 3 comments
Open

Make mithro/actions-includes@main work with private workflows #18

piotrlis opened this issue Mar 17, 2021 · 3 comments

Comments

@piotrlis
Copy link

Executing a check at the beginning of generated workflow doesn't work with private workflows.

Would it be possible to either support private repositories or add possibility to turn off this step?

@piotrlis piotrlis changed the title mithro/actions-includes@main doesn't work with private workflows Make mithro/actions-includes@main work with private workflows Mar 17, 2021
@mithro
Copy link
Owner

mithro commented Mar 17, 2021

Two thoughts;

  • Would be happy for someone to add an option to turn off the "up to date" check.
  • I think you could potentially use the GITHUB_TOKEN to get access to the resources?

@piotrlis
Copy link
Author

piotrlis commented Mar 17, 2021

Thanks for quick answer.

I think setting up GITHUB_TOKEN doesn't help in this case, the script that compares generated workflow with the template uses https://raw.githubusercontent.com and doesn't pass the token: https://github.com/mithro/actions-includes/blob/main/actions_includes/check.py#L37

GitHub
Allows including an action inside another action (by preprocessing the Yaml file). This is how composite actions should have worked. - mithro/actions-includes

@mithro
Copy link
Owner

mithro commented Mar 17, 2021

@piotrlis - We could make it pass the token if it is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants