Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments lining up from included actions #21

Open
mithro opened this issue Mar 18, 2021 · 1 comment
Open

Fix comments lining up from included actions #21

mithro opened this issue Mar 18, 2021 · 1 comment

Comments

@mithro
Copy link
Owner

mithro commented Mar 18, 2021

They need to be indented more.

@mike-potter
Copy link

Also, some comments get stripped from the main action file.

Example src file:

jobs:
  my-job:
    name: My Job
    runs-on: self-hosted
    container:
      # Private Repos: https://github.blog/changelog/2020-09-24-github-actions-private-registry-support-for-job-and-service-containers/
      image: myimage
      # Default actions run as user 1000 (ubuntu)
      # https://stackoverflow.com/questions/58955666/how-to-set-the-docker-user-in-github-actions
      options: --user 1000
    steps:
      - includes: ./.github/includes/my-include

results in the compiled action file:

jobs:
  my-job:
    name: My Job
    runs-on: self-hosted
    container:
      # Private Repos: https://github.blog/changelog/2020-09-24-github-actions-private-registry-support-for-job-and-service-containers/
      image: myimage
      options: --user 1000
    steps:
    - name: ⏰ 🛂 📕 - Checking workflow expansion is up to date
   ...

Notice the comment about "Default actions run as..." between the "image:" and "options:" keys is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants