Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the GitHub expression evaluator / simplifier code #5

Closed
mithro opened this issue Feb 25, 2021 · 1 comment
Closed

Add tests for the GitHub expression evaluator / simplifier code #5

mithro opened this issue Feb 25, 2021 · 1 comment

Comments

@mithro
Copy link
Owner

mithro commented Feb 25, 2021

The tool does some nice stuff around if an input makes a step's if statement a static value, then it removes the step (if: false) or if: condition when if: true.
@mithro
Copy link
Owner Author

mithro commented Mar 4, 2021

This is something that should be expanded....

if: \!startswith(matrix.os, 'ubuntu') && (true && null && startsWith('ubuntu-latest', 'ubuntu'))

mithro added a commit that referenced this issue Mar 5, 2021
@mithro
Adding full expression simplifier.
3b23793 
Now expressions will be simplified if their values are already known.
Produces much nicer output workflows with steps that would never execute
removed.

Fixes #5.
Fixes #8.
@mithro mithro mentioned this issue Mar 5, 2021
Closed
mithro added a commit that referenced this issue Mar 5, 2021
@mithro
Adding full expression simplifier.
223f3ec 
Now expressions will be simplified if their values are already known.
Produces much nicer output workflows with steps that would never execute
removed.

Fixes #5.
Fixes #8.
mithro added a commit that referenced this issue Mar 5, 2021
@mithro
Adding full expression simplifier.
5b8bff2 
Now expressions will be simplified if their values are already known.
Produces much nicer output workflows with steps that would never execute
removed.

Fixes #5.
Fixes #8.
mithro added a commit that referenced this issue Mar 5, 2021
@mithro
Adding full expression simplifier.
c20549e 
Now expressions will be simplified if their values are already known.
Produces much nicer output workflows with steps that would never execute
removed.

Fixes #5.
Fixes #8.
@mithro mithro closed this as completed in 5e72d56 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding full expression simplifier. mithro/actions-includes
1 participant
@mithro