-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate from Travis CI to GitHub Actions #20
Conversation
I would like to test as many popular Linux variants as we can. |
|
||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does git need to be told to enable symlinks on Windows like it does on Travis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now added it to the previous step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why this didn't fail on the windows github action previously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that symlinks were traditionally not supported on Windows. However, some of the latest versions do support them. My guess is that the Windows version used in GHA is newer than the one in Travis. GHA is Azure, after all.
On the other hand, GHA has been using Git for Windows' bash as the default bash shell on Windows. However, that changed to MSYS2 some days ago, and it's probably going to be reverted, before switching again. See actions/runner-images#1525 and this comment from Git for Windows' maintainer in MSYS2's gitter channel: October 21, 2020 9:43 AM.
So, I cannot really tell.
I need some definition of popularity...
|
Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>
Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>
I would say;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The workflow won't run until we merge this right?
That's correct. Meanwhile, you can check the runs in my fork: https://github.com/umarcor/make-env/actions Let's have this merged and I'll add the container based jobs later. |
Close #19
This PR migrates Linux, Windows and macOS jobs from Travis CI to a GitHub Actions workflow.
@mithro, these tests are native (Ubuntu 18.04, Windows Server 2019, and macOS). Which other GNU/Linux variants do you want to test (through containers)?