Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate from Travis CI to GitHub Actions #20

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Nov 8, 2020

Close #19

This PR migrates Linux, Windows and macOS jobs from Travis CI to a GitHub Actions workflow.

@mithro, these tests are native (Ubuntu 18.04, Windows Server 2019, and macOS). Which other GNU/Linux variants do you want to test (through containers)?

@mithro
Copy link
Owner

mithro commented Nov 8, 2020

I would like to test as many popular Linux variants as we can.


- uses: actions/checkout@v2
with:
fetch-depth: 0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does git need to be told to enable symlinks on Windows like it does on Travis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now added it to the previous step.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this didn't fail on the windows github action previously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that symlinks were traditionally not supported on Windows. However, some of the latest versions do support them. My guess is that the Windows version used in GHA is newer than the one in Travis. GHA is Azure, after all.

On the other hand, GHA has been using Git for Windows' bash as the default bash shell on Windows. However, that changed to MSYS2 some days ago, and it's probably going to be reverted, before switching again. See actions/runner-images#1525 and this comment from Git for Windows' maintainer in MSYS2's gitter channel: October 21, 2020 9:43 AM.

So, I cannot really tell.

@umarcor
Copy link
Contributor Author

umarcor commented Nov 8, 2020

I would like to test as many popular Linux variants as we can.

I need some definition of popularity...

  • Debian Buster, Sid
  • Ubuntu 18.04, 19.04, 20.04
  • Fedora 32, 33, 34
  • CentOS 7, 8
  • Arch Linux
  • Alpine Linux 3.11, 3.12
  • OpenSuse?

Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>
Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>
@mithro
Copy link
Owner

mithro commented Nov 8, 2020

I would say;

  • Debian stable, Debian unstable, /maybe/ Debian testing
  • Currently supported LTS versions of Ubuntu + the latest version of Ubuntu (it not an LTS).
  • What ever is the equivalent of the above for Fedora / CentOS.
  • Your favorite Linux variant?

Copy link
Owner

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The workflow won't run until we merge this right?

@umarcor
Copy link
Contributor Author

umarcor commented Nov 8, 2020

The workflow won't run until we merge this right?

That's correct. Meanwhile, you can check the runs in my fork: https://github.com/umarcor/make-env/actions

Let's have this merged and I'll add the container based jobs later.

@mithro mithro merged commit 1530e58 into mithro:master Nov 8, 2020
@umarcor umarcor deleted the ci/gha branch November 8, 2020 05:25
@umarcor umarcor mentioned this pull request Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to using GitHub actions for CI (rather than Travis CI).
2 participants