Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with sync not taking effect #79

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

Alec2435
Copy link
Contributor

Made minor modification which allows the sync function to actually take
effect so that the rules queue can have rules disabled, enabled, and
repiroritized on the fly.

Made minor modification which allows the sync function to actually take
effect so that the rules queue can have rules disabled, enabled, and
repiroritized on the fly.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 90.179% when pulling 396c41d on Alec2435:master into 182778d on mithunsatheesh:master.

Copy link
Owner

@mithunsatheesh mithunsatheesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!. Can you write a unit test around this? If its too much of work consider giving an example of this usecase. Will try to cover it from my end.

Also please bump the package MINOR version in package version in the package.json by one.

@mithunsatheesh mithunsatheesh merged commit 3e36734 into mithunsatheesh:master Sep 28, 2020
@mithunsatheesh mithunsatheesh self-assigned this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants