Support missing fonts and <dimension> tags #10
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for making and maintaining saxlsx, it's a wonderful library.
I've recently encountered an XLSX file that Excel, LibreOffice, Numbers and the Creek library were able to handle correctly, but not saxlsx. The file itself is incorrect, and it would be great if saxlsx was able to tolerate these small errors.
There were 2 issues, this PR fixes both and includes a test XLSX that contains both errors.
Missing fonts
In
xl/styles.xml
:Notice how one of the
<xf>
tags is missingnumFmtId
. Probably related to its fonts:This leads to
@num_fmt_id
beingnil
on line36
inlib/saxlsx/style_collection_parser.rb
. My patch simply callsto_i
on@num_fmt_id
which turns anynil
into0
.Missing
<dimension>
tagI think using the
<dimension>
tag is a brilliant way to very quickly retrieve the number of rows, however some spreadsheets do not include this tag.My patch adds a fallback, if the quick lookup failed it iterates through the rows.
I hope this PR meets your quality requirements and gets merged/released.
Thank you