Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial react-redux implementation: get an image rendering #9

Merged
merged 4 commits into from
Feb 23, 2017

Conversation

kadamwhite
Copy link
Collaborator

Yields
image

I've been struggling a bit with testing sagas, @gnarf -- if you have any bandwidth to review this generally (please don't hold back on the code review, tear it to shreds if you feel like it!) that'd be awesome, but if you don't I can muddle along if I can figure out how to fix this error when I run Jest:

 FAIL  src/redux/__tests__/sagas.test.js
  ● sagas › requestFacesSaga › yields an API call to get faces

    TypeError: (0 , _sagas.requestFacesSaga) is not a function
      
      at Object.<anonymous> (src/redux/__tests__/sagas.test.js:13:51)

@kadamwhite
Copy link
Collaborator Author

Merging following review with @gnarf !

@kadamwhite kadamwhite merged commit 7d64b6d into master Feb 23, 2017
@kadamwhite kadamwhite deleted the add-redux branch February 23, 2017 22:49
@boazsender boazsender added this to in reveiw in 0.1 release Mar 1, 2017
@boazsender boazsender moved this from in reveiw to done in 0.1 release Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants