This repository has been archived by the owner on Jun 1, 2018. It is now read-only.
Fix permission for mitmproxy directory #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue mitmproxy#6. This approach is the same used by official Docker images such as mysql and postgres. Running the container with any mitmproxy tool it will set the required permissions for mitmproxy directory and run the process also with the mitmproxy user. Otherwise it will run the passed arg with the root user. Which allows the user to test the container with any command. Just will not set the directory permission running this way.
|
Sorry, this apparently got lost within the emails for the main repo! Thanks so much for this - this looks fantastic and I'll include it in the next release ASAP. 😃 🍰 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #6.
This approach is the same used by official Docker images such as mysql and postgres.
Running the container with any mitmproxy tool it will set the required permissions for
mitmproxy directory and run the process also with the mitmproxy user.
Otherwise it will run the passed arg with the root user. Which allows the user to
test the container with any command. Just will not set the directory permission running this way.