Make script loading error more verbose

mitmproxy · Nov 11, 2021 · 4478012 · 4478012
1 parent 18a0791
commit 4478012
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@
 * Upstream replays don't do CONNECT on plaintext HTTP requests (#4876, @HoffmannP)
 * Remove workarounds for old pyOpenSSL versions (#4831, @KarlParkinson)
 * Scripts with relative paths are now loaded relative to the config file and not where the command is ran
+* Exception raised when loading script which is not a file now shows which file caused the error.
 
 ## 28 September 2021: mitmproxy 7.0.4
 

diff --git a/mitmproxy/addons/script.py b/mitmproxy/addons/script.py
@@ -77,7 +77,7 @@ def __init__(self, path: str, reload: bool) -> None:
         self.ns = None
 
         if not os.path.isfile(self.fullpath):
-            raise exceptions.OptionsError('No such script')
+            raise exceptions.OptionsError(f'No such script: {self.fullpath}')
 
         self.reloadtask = None
         if reload: