Skip to content

Commit

Permalink
mitmproxy.types -> mitmproxy.coretypes
Browse files Browse the repository at this point in the history
The types name is valuable, and we have a better use for it in collecting and
exposing types for options and commands.

The coretypes module should probably be split up anyway - it contains a
threading base class, a few container objects, and the defintion of our
serialization protocol. I was tempted to rename it to "uncagegorized" for the
sake of honesty.
  • Loading branch information
cortesi committed Dec 17, 2017
1 parent 1f6656c commit 978b8d0
Show file tree
Hide file tree
Showing 34 changed files with 29 additions and 29 deletions.
2 changes: 1 addition & 1 deletion mitmproxy/certs.py
Expand Up @@ -11,7 +11,7 @@
from pyasn1.error import PyAsn1Error
import OpenSSL

from mitmproxy.types import serializable
from mitmproxy.coretypes import serializable

# Default expiry must not be too long: https://github.com/mitmproxy/mitmproxy/issues/815
DEFAULT_EXP = 94608000 # = 24 * 60 * 60 * 365 * 3
Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/contentviews/image/view.py
@@ -1,7 +1,7 @@
import imghdr

from mitmproxy.contentviews import base
from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict
from . import image_parser


Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/contentviews/multipart.py
@@ -1,5 +1,5 @@
from mitmproxy.net import http
from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict
from . import base


Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/contentviews/urlencoded.py
@@ -1,5 +1,5 @@
from mitmproxy.net.http import url
from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict
from . import base


Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
@@ -1,7 +1,7 @@
from abc import ABCMeta, abstractmethod

from collections.abc import MutableMapping
from mitmproxy.types import serializable
from mitmproxy.coretypes import serializable


class _MultiDict(MutableMapping, metaclass=ABCMeta):
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion mitmproxy/master.py
Expand Up @@ -12,7 +12,7 @@
from mitmproxy import log
from mitmproxy.net import server_spec
from mitmproxy.proxy.protocol import http_replay
from mitmproxy.types import basethread
from mitmproxy.coretypes import basethread

from . import ctx as mitmproxy_ctx

Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/net/http/cookies.py
Expand Up @@ -3,7 +3,7 @@
import time
from typing import Tuple, List, Iterable

from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict

"""
A flexible module for cookie parsing and manipulation.
Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/net/http/headers.py
@@ -1,7 +1,7 @@
import re

import collections
from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict
from mitmproxy.utils import strutils

# See also: http://lucumr.pocoo.org/2013/7/2/the-updated-guide-to-unicode/
Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/net/http/message.py
Expand Up @@ -3,7 +3,7 @@

from mitmproxy.utils import strutils
from mitmproxy.net.http import encoding
from mitmproxy.types import serializable
from mitmproxy.coretypes import serializable
from mitmproxy.net.http import headers


Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/net/http/request.py
Expand Up @@ -2,7 +2,7 @@
import urllib
from typing import Optional, AnyStr, Dict, Iterable, Tuple, Union

from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict
from mitmproxy.utils import strutils
from mitmproxy.net.http import multipart
from mitmproxy.net.http import cookies
Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/net/http/response.py
@@ -1,7 +1,7 @@
import time
from email.utils import parsedate_tz, formatdate, mktime_tz
from mitmproxy.utils import human
from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict
from mitmproxy.net.http import cookies
from mitmproxy.net.http import headers as nheaders
from mitmproxy.net.http import message
Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/net/socks.py
Expand Up @@ -3,7 +3,7 @@
import ipaddress

from mitmproxy.net import check
from mitmproxy.types import bidi
from mitmproxy.coretypes import bidi


class SocksError(Exception):
Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/net/tcp.py
Expand Up @@ -14,7 +14,7 @@

from mitmproxy import certs
from mitmproxy import exceptions
from mitmproxy.types import basethread
from mitmproxy.coretypes import basethread

socket_fileobject = socket.SocketIO

Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/net/websockets/frame.py
Expand Up @@ -6,7 +6,7 @@
from mitmproxy.utils import strutils
from mitmproxy.utils import bits
from mitmproxy.utils import human
from mitmproxy.types import bidi
from mitmproxy.coretypes import bidi
from .masker import Masker


Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/proxy/protocol/http2.py
Expand Up @@ -15,7 +15,7 @@
from mitmproxy.proxy.protocol import http as httpbase
import mitmproxy.net.http
from mitmproxy.net import tcp
from mitmproxy.types import basethread
from mitmproxy.coretypes import basethread
from mitmproxy.net.http import http2, headers
from mitmproxy.utils import human

Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/proxy/protocol/http_replay.py
Expand Up @@ -11,7 +11,7 @@
from mitmproxy import connections
from mitmproxy.net import server_spec
from mitmproxy.net.http import http1
from mitmproxy.types import basethread
from mitmproxy.coretypes import basethread
from mitmproxy.utils import human


Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/script/concurrent.py
Expand Up @@ -4,7 +4,7 @@
"""

from mitmproxy import eventsequence
from mitmproxy.types import basethread
from mitmproxy.coretypes import basethread


class ScriptThread(basethread.BaseThread):
Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/stateobject.py
Expand Up @@ -2,7 +2,7 @@
from typing import List
from typing import MutableMapping # noqa

from mitmproxy.types import serializable
from mitmproxy.coretypes import serializable


def _is_list(cls):
Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/tcp.py
Expand Up @@ -3,7 +3,7 @@
from typing import List

from mitmproxy import flow
from mitmproxy.types import serializable
from mitmproxy.coretypes import serializable


class TCPMessage(serializable.Serializable):
Expand Down
2 changes: 1 addition & 1 deletion mitmproxy/websocket.py
Expand Up @@ -3,7 +3,7 @@

from mitmproxy import flow
from mitmproxy.net import websockets
from mitmproxy.types import serializable
from mitmproxy.coretypes import serializable
from mitmproxy.utils import strutils, human


Expand Down
2 changes: 1 addition & 1 deletion pathod/pathoc.py
Expand Up @@ -17,7 +17,7 @@
from mitmproxy.net import websockets
from mitmproxy.net import socks
from mitmproxy.net import http as net_http
from mitmproxy.types import basethread
from mitmproxy.coretypes import basethread
from mitmproxy.utils import strutils

from pathod import log
Expand Down
2 changes: 1 addition & 1 deletion pathod/protocols/http2.py
Expand Up @@ -8,7 +8,7 @@
import mitmproxy.net.http.headers
import mitmproxy.net.http.response
import mitmproxy.net.http.request
from mitmproxy.types import bidi
from mitmproxy.coretypes import bidi

from .. import language

Expand Down
2 changes: 1 addition & 1 deletion pathod/test.py
Expand Up @@ -2,7 +2,7 @@
import time
import queue
from . import pathod
from mitmproxy.types import basethread
from mitmproxy.coretypes import basethread
import typing # noqa


Expand Down
2 changes: 1 addition & 1 deletion test/mitmproxy/contentviews/test_auto.py
@@ -1,6 +1,6 @@
from mitmproxy.contentviews import auto
from mitmproxy.net import http
from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict
from . import full_eval


Expand Down
2 changes: 1 addition & 1 deletion test/mitmproxy/contentviews/test_query.py
@@ -1,5 +1,5 @@
from mitmproxy.contentviews import query
from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict
from . import full_eval


Expand Down
File renamed without changes.
@@ -1,5 +1,5 @@
import re
from mitmproxy.types import basethread
from mitmproxy.coretypes import basethread


def test_basethread():
Expand Down
@@ -1,5 +1,5 @@
import pytest
from mitmproxy.types import bidi
from mitmproxy.coretypes import bidi


def test_bidi():
Expand Down
@@ -1,6 +1,6 @@
import pytest

from mitmproxy.types import multidict
from mitmproxy.coretypes import multidict


class _TMulti:
Expand Down
@@ -1,6 +1,6 @@
import copy

from mitmproxy.types import serializable
from mitmproxy.coretypes import serializable


class SerializableDummy(serializable.Serializable):
Expand Down

0 comments on commit 978b8d0

Please sign in to comment.