New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate asynctest to stdlib's AsyncMock #4020
Comments
We do have a green CI test on Python 3.8: How is the test failing for you? |
We probably want to migrate to the stdlib implementation here, but that requires us to drop Python 3.7 and below. I'd be fine doing this, but we're blocked by PyInstaller which does not support 3.8 yet (pyinstaller/pyinstaller#4311). |
You are using pytest-asyncio already. Replace the |
@bnavigator: works for me as well. If you would like to send a PR, that would be fabulous! 😃 |
This is an implementation of #4020 Tested to work fine here with Python 3.8.6.
Problem Description
test/mitmproxy/addons/test_readfile.py:5 imports
asynctest
which doesn't work with python 3.8 and above.asynctest upstream is aware of this breakage and recommends using the built-in AsyncMock instead. See also asynctest/issues/144 and asynctest/issues/126 .
Fortunately, this is the only test that seems to be affected.
The text was updated successfully, but these errors were encountered: