New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] [WIP] Mitmweb options editor content #2423
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d7bbfca
[web] Change the response format of GET /options.
MatthewShao 2e6f56c
[web] Try toggle options in option modal.
MatthewShao aa01a62
[web] Add keys argument for dump_dict in optmanager.
MatthewShao c1553c7
[web] Broadcast options update in backend.
MatthewShao d889892
[web] List all options in option modal.
MatthewShao e8f3b74
[web] Update css for modal.
MatthewShao 7516f70
[web] Update Option Modal UI and its tests.
MatthewShao 37fea26
Fix the test for websocket connection.
MatthewShao File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,13 @@ | ||
.modal-visible { | ||
display: block; | ||
} | ||
|
||
|
||
.modal-dialog { | ||
overflow-y: initial !important; | ||
} | ||
|
||
.modal-body { | ||
max-height: calc(100vh - 20px); | ||
overflow-y: auto; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,119 @@ | ||
import PropTypes from 'prop-types' | ||
|
||
PureBooleanOption.PropTypes = { | ||
value: PropTypes.bool.isRequired, | ||
onChange: PropTypes.func.isRequired, | ||
} | ||
|
||
function PureBooleanOption({ value, onChange, name, help}) { | ||
return ( | ||
<label> | ||
{ name } | ||
<input type="checkbox" | ||
checked={value} | ||
onChange={onChange} | ||
title={help} | ||
/> | ||
</label> | ||
) | ||
} | ||
|
||
PureStringOption.PropTypes = { | ||
value: PropTypes.string.isRequired, | ||
onChange: PropTypes.func.isRequired, | ||
} | ||
|
||
function PureStringOption( { value, onChange, name, help }) { | ||
let onKeyDown = (e) => {e.stopPropagation()} | ||
return ( | ||
<label> | ||
{ name } | ||
<input type="text" | ||
value={value} | ||
onChange={onChange} | ||
title={help} | ||
onKeyDown={onKeyDown} | ||
/> | ||
</label> | ||
) | ||
} | ||
|
||
PureNumberOption.PropTypes = { | ||
value: PropTypes.number.isRequired, | ||
onChange: PropTypes.func.isRequired, | ||
} | ||
|
||
function PureNumberOption( {value, onChange, name, help }) { | ||
let onKeyDown = (e) => {e.stopPropagation()} | ||
return ( | ||
<label> | ||
{ name } | ||
<input type="number" | ||
value={value} | ||
onChange={onChange} | ||
title={help} | ||
onKeyDown={onKeyDown} | ||
/> | ||
</label> | ||
) | ||
} | ||
|
||
PureChoicesOption.PropTypes = { | ||
value: PropTypes.string.isRequired, | ||
onChange: PropTypes.func.isRequired, | ||
} | ||
|
||
function PureChoicesOption( { value, onChange, name, help, choices }) { | ||
return ( | ||
<label htmlFor=""> | ||
{ name } | ||
<select name={name} onChange={onChange} title={help} selected={value}> | ||
{ choices.map((choice, index) => ( | ||
<option key={index} value={choice}> {choice} </option> | ||
))} | ||
</select> | ||
</label> | ||
) | ||
} | ||
|
||
const OptionTypes = { | ||
bool: PureBooleanOption, | ||
str: PureStringOption, | ||
int: PureNumberOption, | ||
"optional str": PureStringOption, | ||
"sequence of str": PureStringOption, | ||
} | ||
|
||
export default function OptionMaster({option, name, updateOptions, ...props}) { | ||
let WrappedComponent = null | ||
if (option.choices) { | ||
WrappedComponent = PureChoicesOption | ||
} else { | ||
WrappedComponent = OptionTypes[option.type] | ||
} | ||
|
||
let onChange = (e) => { | ||
switch (option.type) { | ||
case 'bool' : | ||
updateOptions({[name]: !option.value}) | ||
break | ||
case 'int': | ||
updateOptions({[name]: parseInt(e.target.value)}) | ||
break | ||
default: | ||
updateOptions({[name]: e.target.value}) | ||
} | ||
} | ||
return ( | ||
<div className="menu-entry"> | ||
<WrappedComponent | ||
children={props.children} | ||
value={option.value} | ||
onChange={onChange} | ||
name={name} | ||
help={option.help} | ||
choices={option.choices} | ||
/> | ||
</div> | ||
) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good change. 👍