add mapremote addon to modify request URLs #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhils
reviewed
Jul 3, 2020
mitmproxy/addons/mapremote.py
Outdated
| return | ||
|
|
||
| replacements = 0 | ||
| obj.url, replacements = re.subn(search, repl, strutils.escaped_str_to_bytes(obj.pretty_url), flags=re.DOTALL) |
There was a problem hiding this comment.
The URL is surrogate-escaped UTF-8, so we should do obj.pretty_url.encode("utf8", "surrogateescape"). We're doing a bit of a weird encoding dance here that's tricky to explain, but escaped_str_to_bytes would interpret escape sequences in a URL as raw bytes, which would fail in some edge cases.
There was a problem hiding this comment.
Do you think this is what causes the failing unit test on windows? (e.g. TestMapRemoteFile; see #4046 (comment))
mplattner
commented
Jul 3, 2020
mplattner
force-pushed
the
mapremote-addon
branch
from
7da3512
to
cee4da4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new addon (
MapRemote) to rewrite URLs of requests before the request is performed.refs #3948
Checklist