Adding support for server facing SSL cipher suite specification #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for specifying cipher suites on both sides of the proxy instead of just the one.
Differentiated client ciphers and added server ciphers.
Forgot to change ciphers->client_ciphers.
|
Excellent work, thanks a lot! 😄 |
mhils
added a commit
that referenced
this pull request
Mar 2, 2015
Adding support for server facing SSL cipher suite specification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for specifying ciphers on the server side of the proxy as part of its CLIENTHELLO(--server-ciphers). It also modifies the current cipher(--ciphers) parameter clarify that it is for the client facing side of the proxy(--client-ciphers). I tested and observed, with wireshark, ciphers that I expected both leaving and coming to the proxy.
This is in regards to feature issue/request mitmproxy#649.