mitmweb: Allow up to 4GB dump to be uploaded #6373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-wy
changed the title
mhils
approved these changes
Sep 19, 2023
|
Just tried the latest version, still happening with a 400 Mb file |
|
My bad, it just takes a really long time to upload it. Sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A temporary fix to allow up to 4GB dump to be uploaded by supplying max_buffer_size of the HTTPServer constructor to be 2**32 (4GB).
(Perhaps it is better to be a configurable item, or change the post mechanism to stream instead if there ever is any security concern implied due to usage or hardware limitations)
By default, if no argument is supplied, the maximum buffer size is 100MB, which causes saved dump file to be unreadable through the web interface.
Reference Documentation: Link
Possibly:
Resolves #4651, resolves #5609
Checklist