Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip double slash from websocket URL, fix #6452 #6454

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Strip double slash from websocket URL, fix #6452 #6454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e22d2d2
strip double slash from websocket URL, fix #6452
mhils Nov 4, 2023
912392b
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased: mitmproxy next

* Fix a bug introduced in mitmproxy 10.1.2 where mitmweb would fail to establish
a WebSocket connection. Affected users may need to clear their browser cache
or hard-reload mitmweb (Ctrl+Shift+R).
([#6454](https://github.com/mitmproxy/mitmproxy/pull/6454), @mhils)


## 03 November 2023: mitmproxy 10.1.2
Expand Down
2 changes: 1 addition & 1 deletion web/src/js/backends/websocket.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default class WebsocketBackend {
connect() {
this.socket = new WebSocket(
location.origin.replace("http", "ws") +
location.pathname +
location.pathname.replace(/\/$/, "") +
"/updates"
);
this.socket.addEventListener("open", () => this.onOpen());
Expand Down