Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mitmweb splitter becoming drag and drop #6492

Merged
merged 4 commits into from Dec 12, 2023
Merged

Fix mitmweb splitter becoming drag and drop #6492

merged 4 commits into from Dec 12, 2023

Conversation

xBZZZZ
Copy link
Contributor

@xBZZZZ xBZZZZ commented Nov 18, 2023

Description

before
before.webm
after
after.webm

Checklist

  • I have updated tests where applicable.
  • I have added an entry to the CHANGELOG.

@xBZZZZ
Copy link
Contributor Author

xBZZZZ commented Nov 18, 2023

also it's my first time writing weird preprocessed javascript and using react library, so please read code before merging to make sure i did not break something or write inefficient code

mhils
mhils approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This somehow slipped through the cracks - apologies for the long wait! This looks excellent, thanks so much for fixing this! 😃 🍰

@mhils mhils enabled auto-merge (squash) December 12, 2023 18:18
@mhils mhils merged commit 13c976d into mitmproxy:main Dec 12, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhils mhils mhils approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xBZZZZ @mhils