[INVESTIGATION] mitosheet: optimize out unneeded code after deletes #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements optimizing out unneeded code after a delete. See the core algorithm for the optimization in the compiler utilities. Generally, pretty happy with how it works, but not the actual implementation (it's very messy). As such, let's not merge this.
What I liked from this implementation:
What I didn't like from this implementation:
Testing
Do some imports, merges, and pivots, and then delete data frames. If the data frame you delete was not used in any later step, it's creation and edits should disappear as well!
Documentation
No. We're also not merging.