You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently, we reference sheets by sheet ids. This is nice in-so-far as it allows us to store sheets as an array, and terrible in so far as it complicates a lot of things:
It also leads to a few bugs that currently exist in the app, that are very hard to fix up otherwise:
Editing pivot tables that have dataframes with lower sheet indexes deleted leads to the params not being gotten properly (aka, you cannot edit them).
Describe the solution you'd like
We'd like to move from sheet indexes -> sheet ids. Doing so requires a few things:
Refactoring the frontend to think about sheet ids, rather than sheet indexes.
Refactoring the steps to take sheet ids, rather than sheet indexes.
Refactoring the apis to take sheet ids, rather than sheet indexes.
Upgrading all previous analyses that take sheet indexes to use sheet ids. Note that this a bit of an undertaking, as we need a good algorithm for building/maintaing sheet ids over time (which, needs some more infrastructure).
All-in-all, I expect this to be a 3-5 day task to complete. It will unlock a considerable amount of new functionality and solutions to problems, and generally seems like something we should have done a long time ago.
Describe alternatives you've considered
I haven't thought much about alternatives. Some form of ID seems necessary, although I guess we could layer it on top of the current system. Hmm.
The text was updated successfully, but these errors were encountered:
How to actually move to sheet id: the sheet id should be an incrementing number, that goes up by one during every additional dataframe or every import.
This will allow us to preserve the replaying of analyses properly, while still having a unique ID per dataframe. Weird. It's not exactly an ID.
Or it's like: the IDs need to be consistently applied to the sheet number across repeats of the same analysis.
All passed dataframes have sheet indexes < 0 (counting up to 0).
All imported/created data frames have indexes >= 0 (starting at 0).
This would do some pretty cool things to replaying the analysis, namely where we could avoid issues if users go from not passing a dataframe to passing a dataframe. The analysis would still replay properly. Cool!
Is your feature request related to a problem? Please describe.
Currently, we reference sheets by sheet ids. This is nice in-so-far as it allows us to store sheets as an array, and terrible in so far as it complicates a lot of things:
It also leads to a few bugs that currently exist in the app, that are very hard to fix up otherwise:
Describe the solution you'd like
We'd like to move from sheet indexes -> sheet ids. Doing so requires a few things:
All-in-all, I expect this to be a 3-5 day task to complete. It will unlock a considerable amount of new functionality and solutions to problems, and generally seems like something we should have done a long time ago.
Describe alternatives you've considered
I haven't thought much about alternatives. Some form of ID seems necessary, although I guess we could layer it on top of the current system. Hmm.
The text was updated successfully, but these errors were encountered: