Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in variable name xbout #23

Closed
ShawnMilo opened this issue Apr 30, 2015 · 4 comments
Closed

typo in variable name xbout #23

ShawnMilo opened this issue Apr 30, 2015 · 4 comments

Comments

@ShawnMilo
Copy link
Contributor

The function set_about has a variable xabout. Inside the function, there is a typo, xbout. However, this function is never called (at least within xbundle), even in tests.

Should the function be removed, or the typo fixed? Also, this same typo exists in all versions of xbundle I've seen (xbundle, latex2edx, edx2course_axis).
@itsbenweeks
Copy link
Contributor

I'm all for keeping things lean. If latex2edx doesn't use this function, then let's get rid of it.

@ShawnMilo
Copy link
Contributor Author

I like the idea of deleting as well. Especially because we actually can be sure no consumers of the package are using it; they would have run into the bug.

@ShawnMilo ShawnMilo mentioned this issue May 1, 2015
Merged
@itsbenweeks
Copy link
Contributor

Thank you for the PR!

@ShawnMilo
Copy link
Contributor Author

You're welcome. Just doing my job. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itsbenweeks @ShawnMilo