Merge pull request #50 from amir-qayyum-khan/fix/aq/handle_sid_none

Handle unmatched gradebook students better #47
mitodl · Nov 27, 2018 · b798b86 · b798b86
2 parents b37efb6 + 0636b93
commit b798b86
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/pylmod/gradebook.py b/pylmod/gradebook.py
@@ -932,6 +932,7 @@ def _spreadsheet2gradebook_multi(
                     'Error in spreadsheet2gradebook: cannot find '
                     'student id for email="%s"\n', email
                 )
+                continue
             for field in row.keys():
                 if field in non_assignment_fields:
                     continue

diff --git a/pylmod/tests/test_gradebook.py b/pylmod/tests/test_gradebook.py
@@ -179,7 +179,8 @@ def _get_multigrade(self, approve_grades=False):
         """Get a list of spreadsheet rows as dictionaries
 
         Get a list of spreadsheet row values to test submitting
-        grades in a spreadsheet to the LMod web service.
+        grades in a spreadsheet to the LMod web service. Only
+        grades with sid not equal to none are valid.
 
         Args:
             approve_grades (boolean): list of spreadsheet rows as
@@ -194,11 +195,6 @@ def _get_multigrade(self, approve_grades=False):
                  'mode': 2,
                  'numericGradeValue': 2.2,
                  'studentId': 1},
-                {'assignmentId': 1,
-                 'isGradeApproved': approve_grades,
-                 'mode': 2,
-                 'numericGradeValue': 1.1,
-                 'studentId': None},
         ]
 
     def _register_get_gradebook(self, send_data=True):