Fix style and logic issues, per @noisecapella's comments on PR #500.

mitodl · Aug 18, 2015 · 56b438c · 56b438c
1 parent ab88e1f
commit 56b438c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/ui/jstests/test-learning-resource.jsx b/ui/jstests/test-learning-resource.jsx
@@ -211,15 +211,15 @@ define(['QUnit', 'jquery', 'react', 'lodash', 'learning_resources',
           assert.equal($vocabSelect.size(), 1);
 
           // first vocab, two options
-          var $vocabOptions = $($vocabSelect).find("option");
+          var $vocabOptions = $vocabSelect.find("option");
           assert.equal($vocabOptions.size(), 2);
 
           assert.equal($vocabOptions[0].selected, true);
           assert.equal($vocabOptions[1].selected, false);
 
           // TestUtils.Simulate.change only simulates a change event,
           // we need to update the value first ourselves
-          $($vocabSelect).val("prerequisite").trigger('change');
+          $vocabSelect.val("prerequisite").trigger('change');
           React.addons.TestUtils.Simulate.change($vocabSelect);
           component.forceUpdate(function() {
             assert.equal($vocabOptions[0].selected, false);

diff --git a/ui/static/ui/js/learning_resources.jsx b/ui/static/ui/js/learning_resources.jsx
@@ -47,7 +47,7 @@ define('learning_resources', [
 
   var VocabSelect = React.createClass({
     render: function () {
-      var options = [];
+      var options;
       options = _.map(this.props.vocabs, function(vocab) {
         return {
           id: vocab.vocabulary.slug,
@@ -97,6 +97,7 @@ define('learning_resources', [
       _.forEach(this.props.vocabs, function(vocab) {
         if (vocab.vocabulary.slug === selectedVocabulary.slug) {
           currentVocabulary = vocab;
+          return false;
         }
       });