Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved stage1 plugin into production #263

Merged
merged 1 commit into from
May 3, 2016
Merged

Moved stage1 plugin into production #263

merged 1 commit into from
May 3, 2016

Conversation

noisecapella
Copy link
Contributor

@noisecapella noisecapella commented May 3, 2016

What are the relevant tickets?

What's this PR do?

  • Moves the stage1 babel requirement from devDependencies to dependencies so production builds can use it
  • Adds --bail to webpack command so it returns a non-zero status code on error (surprisingly not the default behavior)

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

Screenshots (if appropriate)

What GIF best describes this PR or how it makes you feel?

@bdero bdero temporarily deployed to micromasters-ci-pr-263 May 3, 2016 17:57 Inactive
@giocalitri
Copy link
Contributor

details for the change in webpack_if_prod.sh?

@noisecapella
Copy link
Contributor Author

The --bail command causes webpack to exit with a non-zero code if there's an error. Since it didn't do this before we were unaware of the requirements error. Some context: webpack/webpack#708 (comment)

@giocalitri
Copy link
Contributor

then it is 👍

@noisecapella noisecapella merged commit d46c916 into master May 3, 2016
@noisecapella noisecapella deleted the gs/fix_prod_js branch May 3, 2016 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants