Profiles creation #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giocalitri
force-pushed
the
gdm_profile_#73
branch
from
a18c9d9
to
8446aab
Compare
|
|
||
| def update_profile_from_edx(backend, user, response, is_new, *args, **kwargs): # pylint: disable=unused-argument | ||
| """ | ||
| Gets profile informations from EDX and saves them in the user profile |
There was a problem hiding this comment.
information not informations.
|
👍 from me after you address my comments. George is also reviewing too, it seems. |
| access_token = response.get('access_token') | ||
| if not access_token: | ||
| # this should never happen for the edx oauth provider, but just in case... | ||
| return |
There was a problem hiding this comment.
Can we log this case?
|
Functionality works great |
|
I think I addressed all the comments |
| @@ -14,7 +14,7 @@ class EdxOrgOAuth2(BaseOAuth2): | |||
| name = 'edxorg' | |||
| ID_KEY = 'edx_id' | |||
| REQUEST_TOKEN_URL = None | |||
| EDXORG_BASE_URL = getattr(settings, 'EDXORG_BASE_URL', 'https://courses.edx.org/') | |||
| EDXORG_BASE_URL = getattr(settings, 'EDXORG_BASE_URL') | |||
There was a problem hiding this comment.
Why not settings.EDXORG_BASE_URL here? It will always exist
There was a problem hiding this comment.
you are right: just missed
|
Just one nit, feel free to squash and merge 👍 |
Profiles get created during user creation (via signal) and populated if it is the backend is EDX
giocalitri
force-pushed
the
gdm_profile_#73
branch
from
4d1bd6e
to
a17bba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
fixes #73
What's this PR do?
Creates a Profile for the user and populates it with the data existing in the connected EDX instance
Where should the reviewer start?
pipeline_api.pyHow should this be manually tested?
Add some personal info for your user on edx and then login again on micromasters.
The user should be new on micromasters otherwise the profile will not be updated with the info from edx
Any background context you want to provide?
you need a working micromasters properly configured with a local instance of EDX
What GIF best describes this PR or how it makes you feel?