Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to mitol.common.envs #2003

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Switched to mitol.common.envs #2003

merged 1 commit into from
Nov 25, 2020

Conversation

rhysyngsun
Copy link
Collaborator

Pre-Flight checklist

  • Testing
    • Code is tested
    • Changes have been manually tested
  • Settings
    • New settings are documented and present in app.json

What are the relevant tickets?

Part of #1951

What's this PR do?

Switches current usages of mitxpro.envs to mitol.common.envs

How should this be manually tested?

  • Tests should pass
  • The application should start and a quick smoke test works

@odlbot odlbot temporarily deployed to xpro-ci-pr-2003 November 20, 2020 22:17 Inactive
@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #2003 (49f1a67) into master (9aacb13) will increase coverage by 0.02%.
The diff coverage is 82.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2003      +/-   ##
==========================================
+ Coverage   83.64%   83.66%   +0.02%     
==========================================
  Files         172      171       -1     
  Lines        9800     9699     -101     
  Branches     1028     1013      -15     
==========================================
- Hits         8197     8115      -82     
+ Misses       1364     1350      -14     
+ Partials      239      234       -5     
Impacted Files Coverage Δ
authentication/views.py 78.35% <ø> (-0.44%) ⬇️
cms/wagtail_hooks.py 80.00% <ø> (ø)
courses/management/utils.py 54.83% <0.00%> (ø)
...aldev/seed/management/commands/delete_seed_data.py 0.00% <0.00%> (ø)
mitxpro/models.py 93.18% <ø> (ø)
sheets/coupon_assign_api.py 22.51% <0.00%> (ø)
users/serializers.py 93.13% <ø> (ø)
courses/api.py 92.70% <50.00%> (ø)
users/management/commands/retire_users.py 74.41% <50.00%> (+0.60%) ⬆️
mitxpro/celery_utils.py 58.82% <58.82%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aacb13...49f1a67. Read the comment docs.

@rhysyngsun rhysyngsun temporarily deployed to xpro-ci-pr-2003 November 23, 2020 15:03 Inactive
@rhysyngsun rhysyngsun temporarily deployed to xpro-ci-pr-2003 November 23, 2020 15:53 Inactive
@rhysyngsun rhysyngsun temporarily deployed to xpro-ci-pr-2003 November 23, 2020 16:04 Inactive
Copy link
Contributor

@gsidebo gsidebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@rhysyngsun rhysyngsun merged commit b19b989 into master Nov 25, 2020
@rhysyngsun rhysyngsun deleted the nl/migrate_envs branch November 25, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants