Add support for IE11 #956
Add support for IE11 #956
Conversation
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
==========================================
+ Coverage 93.31% 98.22% +4.91%
==========================================
Files 251 131 -120
Lines 8930 3672 -5258
Branches 506 0 -506
==========================================
- Hits 8333 3607 -4726
+ Misses 498 65 -433
+ Partials 99 0 -99Continue to review full report at Codecov.
|
| @@ -26,15 +26,13 @@ module.exports = { | |||
| }, | |||
| babelSharedLoader: { | |||
| test: /\.jsx?$/, | |||
| exclude: /node_modules/, | |||
There was a problem hiding this comment.
Can we do something like this and specifically include certain node_modules files instead of including the full contents?
There was a problem hiding this comment.
What files or directories would be included though? As far as I can tell it is complaining about arrow functions being referenced which could be used in any number of dependencies or libraries they depend on, etc.
There was a problem hiding this comment.
Ah right, sorry I misunderstood the root problem
|
@gsidebo By default it tries to fetch JS and CSS from |
There was a problem hiding this comment.
Based on the Travis builds, this looks like it's adding 2-3 minutes to the Javascript test suite build step. If there's no good way to determine which installed packages are including arrow functions and selectively include those to be transpiled, this is good to go 👍
Pre-Flight checklist
What are the relevant tickets?
None
What's this PR do?
IE11 was not working properly because arrow functions which were present in the webpack bundle aren't supported in IE11. This PR configures webpack to also transpile libraries used by our bundle in addition to our own code. I don't know what the downsides are but I assume webpack will take longer to compile, will probably use more memory, and the bundles will probably be larger than before.
hero.jsis not transpiled at all so the default parameter is removed so that it won't cause a syntax error.Note that the hero banner video still doesn't work but this is outside the scope of this PR.
How should this be manually tested?
Go to the home page. You should be able to see the "sign in" and "create account" buttons.
What GIF best describes this PR or how it makes you feel?