Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pytest version #125

Merged
merged 1 commit into from Jun 27, 2023
Merged

Unpin pytest version #125

merged 1 commit into from Jun 27, 2023

Conversation

rhysyngsun
Copy link
Collaborator

What are the relevant tickets?

Closes #124

Description (What does it do?)

I have two commits here:

  • The first is a commit with changes to support a docker-compose container that has pants setup. I've been running into obtuse issues on my local machine with their binaries so I needed to do this just to work on the issues.
  • The second commit is the actual fix here - it overrides the package distribution's pytest requirement to be any version above 7, but still permits the project itself to be more opinionated and even differ for running tests.

How can this be tested?

  • Run pants package ::
  • Run pip install pkginfo on your host system to easily inspect the package.
  • Run pkginfo dist/mitol_django_common-2023.1.17-py3-none-any.whl, you should see output like this indicating the new pytest requirements as mentioned above:
requires_dist: ['django-redis (~=5.0.0)', 'django-webpack-loader (>=0.7.0)', 'django (<4.0,>=2.2.12)', 'factory-boy (~=3.2)', 'pytest (>=7.0.0)', 'pytz (>=2020.4)', 'requests (>=2.20.0)', 'setuptools', 'typing-extensions']

Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works with and w/out docker; and it's great to have the docker option now 👍

@rhysyngsun rhysyngsun merged commit b6be18e into main Jun 27, 2023
6 checks passed
@rhysyngsun rhysyngsun deleted the nl/unpin-pytest branch June 27, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

having ol-django packages as dependencies limits pytest version to 6.1.2
2 participants