Make LTIBase.is_role() an instance method #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also like to see this pull request merged in. |
|
It looks like the mistake got in with commit ffd3d1d for !84 -- it was a real static method before, but self was added as part of that code move and @staticmethod didn't get removed. Also travis fails, tests are broken. Maybe not so easy to fix because API change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
None.
What does this PR do?
This PR proposes to remove
@staticmethodfrom the definition ofis_role()of LTIBase class.How should this be manually tested?
We can check if the call
lti.is_role("role-name-here")is possible or not.Where should the reviewer start?
https://github.com/yuttie/pylti/blob/make-is_role-instance-method/pylti/common.py#L549
Any background context you want to provide?
Since the signature of the method includes
self, I believe this method was mistakenly marked as a static method.