Fix: filedescriptor out of range in select() #984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreati
reviewed
Apr 17, 2024
| @@ -285,8 +285,10 @@ class Broker(mitogen.master.Broker): | |||
| the exuberant syscall expense of EpollPoller, so override it and restore | |||
| the poll() poller. | |||
| """ | |||
| poller_class = mitogen.core.Poller | |||
There was a problem hiding this comment.
I've just noticed the above docstring mentions "does not need the exuberant syscall expense of EpollPoller, so override it and restore the poll() poller" written by dw in 7b129e8. That predates Poller switching from select.poll() to select.select() in 9bcd2ec.
Your approach using if/else, instead of PREFERRED_POLLER makes more sense now.
This was referenced Apr 18, 2024
|
Superseded by #1065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #957