Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-techniques for T1584 and T1588 incorrect in generate Excel files #270

Closed
reginaelwell opened this issue Mar 5, 2021 · 2 comments · Fixed by #279
Closed

Sub-techniques for T1584 and T1588 incorrect in generate Excel files #270

reginaelwell opened this issue Mar 5, 2021 · 2 comments · Fixed by #279
Assignees
Labels
bug Something isn't working timescale/imminent Ready to be assigned to developers
Milestone

Comments

@reginaelwell
Copy link

I've noticed that sub-techniques for T1584 and T1588 are incorrect in generate Excel files. Display in the Navigator and generated JSON files appear to be unaffected.

T1584 has sub-techniques for T1583 in generated Excel files.

T1584: Compromise Infrastructure
T1583.005: Botnet
T1583.002: DNS Server
T1583.001: Domains
T1583.004: Server
T1583.003: Virtual Private Server
T1583.006: Web Services

T1588 has a mix of sub-techniques for T1587 and T1588.

T1588: Obtain Capabilities
T1587.002: Code Signing Certificates
T1587.003: Digital Certificates
T1587.004: Exploits
T1587.001: Malware
T1588.002: Tool
T1588.006: Vulnerabilities

@reginaelwell reginaelwell changed the title Sub-techniques for T1584 and T1588 incorrect in generate Excel files Sub-techniques for T1584 and T1588 incorrect in generate Excel & JSON files Mar 5, 2021
@reginaelwell reginaelwell changed the title Sub-techniques for T1584 and T1588 incorrect in generate Excel & JSON files Sub-techniques for T1584 and T1588 incorrect in generate Excel files Mar 5, 2021
@isaisabel isaisabel added the bug Something isn't working label Mar 8, 2021
@isaisabel
Copy link
Contributor

Hi @reginaelwell,

This is an interesting bug. The objects in question have the same name, but different ATT&CK IDs. It appears that the excel exporter doesn't take the differing IDs into account and uses the wrong IDs (but correct name) when IDs are enabled under matrix layout. For example:

Screen Shot 2021-03-08 at 10 47 35 AM

Screen Shot 2021-03-08 at 10 50 37 AM

I'm 99% sure the bug occurs in this line of code, where the sub-technique name is used as the key to lookup the ID. If this is the case, line 148 may also have bugs associated with it (in the case of techniques with the same name, which shouldn't occur within the current dataset but could in the future).

As you noted, this only occurs in the excel exporter. The matrix layout and SVG exporter seem unaffected.

@isaisabel isaisabel added this to the Version 4.3 milestone Mar 8, 2021
@isaisabel isaisabel added the timescale/imminent Ready to be assigned to developers label Mar 8, 2021
@iguannalin iguannalin self-assigned this Mar 31, 2021
@iguannalin iguannalin linked a pull request Apr 5, 2021 that will close this issue
isaisabel added a commit that referenced this issue Apr 6, 2021
…h-same-names

Bugs/#270 subtechniques with same names
@isaisabel
Copy link
Contributor

This bug has been addressed in #279 and is now fixed on develop. It will be updated in the live application (on the master branch) with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working timescale/imminent Ready to be assigned to developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants