Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active sub-techniques are not displayed after filtering #298

Closed
peterkimbler opened this issue May 20, 2021 · 3 comments · Fixed by #310
Closed

Active sub-techniques are not displayed after filtering #298

peterkimbler opened this issue May 20, 2021 · 3 comments · Fixed by #310
Labels
enhancement New feature or request Points: 1 1 agile story point timescale/imminent Ready to be assigned to developers
Milestone

Comments

@peterkimbler
Copy link

Reproducible Steps

  • https://mitre-attack.github.io/attack-navigator/
  • Create New layer -> Enterprise
  • Click "Expand sub-techniques"
  • Select "Active Scanning (T1595)" and "Botnet (T1583.005)"
  • Right click -> Invert Selection
  • Click "Toggle state"
  • Click "Show/Hide disabled"

Actual Output

image

Expected Output

"Active Scanning (T1595)" and "Botnet (T1583.005)" displayed in two columns.

@anig1scur
Copy link

anig1scur commented May 20, 2021

A workaround is to select "Acquire Infrastructure(T1583)" in the same time.

It seems that there is no way to show a sub-technique in single column, which needs parent-technique to hold on.

@isaisabel
Copy link
Contributor

isaisabel commented May 20, 2021

Yes I think this is sort of expected behavior -- if the parent technique is hidden, so are all sub-techniques even if they are enabled. We may want to consider making a change to this behavior however since it can lead to hiding data the user didn't intend to hide.

Written as a user story:

As a user, I want to be able to see enabled sub-techniques even if their parents are disabled and hide disabled techniques is enabled. In this case the parent technique should be also be shown for context, but with the usual disabled style applied to denote that it is disabled and would otherwise be hidden.

@isaisabel isaisabel added enhancement New feature or request timescale/imminent Ready to be assigned to developers labels May 20, 2021
@iguannalin iguannalin linked a pull request Jun 23, 2021 that will close this issue
@isaisabel isaisabel added this to the Version 4.4 milestone Jun 24, 2021
@isaisabel isaisabel added the Points: 1 1 agile story point label Jun 24, 2021
isaisabel added a commit that referenced this issue Jun 24, 2021
…btechniques

Feature/#298 show active subtechniques
@isaisabel
Copy link
Contributor

This has been added in #310 and is now present on the develop branch. It will be deployed to the live instance in version 4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Points: 1 1 agile story point timescale/imminent Ready to be assigned to developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants