Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix and enhance the render layer as SVG functionality #223

Merged
merged 5 commits into from
Sep 23, 2020

Conversation

Che4ter
Copy link
Contributor

@Che4ter Che4ter commented Sep 3, 2020

In the new render layer as SVG version, the technique sort order was no longer honored.
This pull requests ads the sorting again.

@Che4ter Che4ter changed the title Bugfix, maintain the sort order when exporting as SVG. Bugfix and enhance the render layer as SVG functionality Sep 3, 2020
@Che4ter
Copy link
Contributor Author

Che4ter commented Sep 3, 2020

In the version 2.3.2 it was possible to hide the gradient in the svg export. The new version was missing this option, therefore I added it again.

isaisabel added a commit that referenced this pull request Sep 23, 2020
isaisabel added a commit that referenced this pull request Sep 23, 2020
SVG Exporter: sorting and legend/gradient display
@isaisabel isaisabel merged commit ea1d727 into mitre-attack:develop Sep 23, 2020
@isaisabel
Copy link
Contributor

Hi @Che4ter,

Thank you for submitting this improvement. I had to make some additional changes in #232:

  • Fixed a crash that could occur in certain layer configurations when the gradient was hidden in the exporter
  • Legend display settings now only hide the user-defined legend, instead of the whole legend container. Previously disabling "show legend" hid the legend and scoring gradient since the whole box was hidden -- there was no way for the user to only hide the legend but not the scoring gradient. The legend container is now hidden if the user-defined legend and the scoring gradient are individually hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants